Reposition guide within help widget#4271
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Jan 14, 2025
Merged
Conversation
Contributor
Author
|
@walterbender & @pikurasa. Kindly review it. |
Member
|
I think this is a good change. However, you have included many unrelated changes to this PR as well, including some string changes that impact translation. Please make these changes in a separate PR. |
js/turtledefs.js
Outdated
| "myblocks" | ||
| ], | ||
| ["graphics", "pen", "media", "sensors", "ensemble"] | ||
| [ |
js/turtledefs.js
Outdated
| _("Mr Mouse is our Music Blocks conductor.") + | ||
| " " + | ||
| _("Mr Mouse encourages you to explore Music Blocks.") + | ||
| _("Mr Mouse encourages you to explore Music Blocks.") + |
js/turtledefs.js
Outdated
| _("Mr Mouse encourages you to explore Music Blocks.") + | ||
| " " + | ||
| _("Let us start our tour!"), | ||
| _("Let us start our tour!"), |
js/turtledefs.js
Outdated
| window.btoa( | ||
| base64Encode(SCROLLUNLOCKBUTTON)) | ||
|
|
||
| window.btoa(base64Encode(SCROLLUNLOCKBUTTON)) |
js/turtledefs.js
Outdated
|
|
||
| window.btoa(base64Encode(SCROLLUNLOCKBUTTON)) | ||
| ]); | ||
| // TODO: JavaScript Editor |
js/turtledefs.js
Outdated
| window.btoa( | ||
| base64Encode(WRAPTURTLEBUTTON)) | ||
|
|
||
| window.btoa(base64Encode(WRAPTURTLEBUTTON)) |
js/turtledefs.js
Outdated
| window.btoa( | ||
| base64Encode(RESTORETRASHBUTTON)) | ||
|
|
||
| window.btoa(base64Encode(RESTORETRASHBUTTON)) |
Ubayed-Bin-Sufian
force-pushed
the
mb_guide_link_reposition
branch
2 times, most recently
from
edda5c4 to
7cc73af
Compare
Ubayed-Bin-Sufian
force-pushed
the
mb_guide_link_reposition
branch
from
7cc73af to
3d0cfeb
Compare
Contributor
Author
@walterbender I have removed the unrelated changes. Please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request repositions the guide link within the help widget to enhance usability for students by directing them to the guide.html file for study purposes.
Changes introduced
Screenshots/video
Screenshare.-.2025-01-14.3_07_18.PM.mp4
Checklist